Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite observers to use std::vector #2615

Merged
merged 9 commits into from
Nov 27, 2023
Merged

Rewrite observers to use std::vector #2615

merged 9 commits into from
Nov 27, 2023

Conversation

alkino
Copy link
Member

@alkino alkino commented Nov 17, 2023

No description provided.

Copy link

✔️ 3de8911 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ 4a79b2d -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@alkino alkino force-pushed the cornu/rewrite_observers branch from 4a79b2d to da865a3 Compare November 22, 2023 09:17
@alkino alkino changed the base branch from master to cornu/rewrite_resources November 22, 2023 09:18
@bbpbuildbot

This comment has been minimized.

Base automatically changed from cornu/rewrite_resources to master November 22, 2023 11:20
@alkino alkino force-pushed the cornu/rewrite_observers branch from 6985166 to 26fb7f0 Compare November 22, 2023 11:49
Copy link

✔️ 26fb7f0 -> Azure artifacts URL

Copy link

✔️ 7222e02 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ 9388b1e -> Azure artifacts URL

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5721cc9) 66.20% compared to head (a28e8f2) 66.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2615   +/-   ##
=======================================
  Coverage   66.20%   66.20%           
=======================================
  Files         559      559           
  Lines      108957   108953    -4     
=======================================
  Hits        72132    72132           
+ Misses      36825    36821    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

This reverts commit 26fb7f0.
@alkino alkino marked this pull request as ready for review November 23, 2023 17:37
Copy link

✔️ a28e8f2 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@alkino alkino closed this Nov 24, 2023
@alkino alkino reopened this Nov 24, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

✔️ a28e8f2 -> Azure artifacts URL

Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The C++ parts look very reasonable.

src/nrnpython/CMakeLists.txt Show resolved Hide resolved
@ohm314 ohm314 enabled auto-merge (squash) November 27, 2023 10:47
@ohm314 ohm314 merged commit 1009732 into master Nov 27, 2023
57 checks passed
@ohm314 ohm314 deleted the cornu/rewrite_observers branch November 27, 2023 10:48
@alkino alkino mentioned this pull request Nov 27, 2023
iomaganaris pushed a commit that referenced this pull request Nov 27, 2023
- After #2514 , #2615 and #2616 Lists are not used anymore in the code and can be removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants