-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite observers to use std::vector #2615
Conversation
✔️ 3de8911 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
✔️ 4a79b2d -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
4a79b2d
to
da865a3
Compare
This comment has been minimized.
This comment has been minimized.
6985166
to
26fb7f0
Compare
✔️ 26fb7f0 -> Azure artifacts URL |
✔️ 7222e02 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
✔️ 9388b1e -> Azure artifacts URL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2615 +/- ##
=======================================
Coverage 66.20% 66.20%
=======================================
Files 559 559
Lines 108957 108953 -4
=======================================
Hits 72132 72132
+ Misses 36825 36821 -4 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
This reverts commit 26fb7f0.
✔️ a28e8f2 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
✔️ a28e8f2 -> Azure artifacts URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The C++ parts look very reasonable.
No description provided.