-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nilearn-style reporting (Issue #341) #342
Conversation
Thx for opening the PR ! |
Great! Will do. |
@man-shu please let me know when this is ready for review. |
Yes @bthirion, will do! |
Hi @man-shu , Can you fix the CI and then let me know ? |
Yes, on it! |
32c6f1e
to
6f94ebb
Compare
Hello @bthirion, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx ! I just put some minro comments.
May main question is: do we have at least a smoke test that runs the reports ?
Thanks, @bthirion for the review and comments. The tests run by the Circle CI generate the reports with the new reporting, I checked the log and it does seem to be working. It prints a line "Report created and saved to - " when a report is created. But I am not sure if that qualifies as a smoke test. Let me know if a more rigorous test is needed (I might need to consult someone, maybe Nicolas, on how to write one). |
OK, so indeed a test should be run, at least to make sure that documentation generation runs. But: I propose to defer it to a frtcoming PR. Please address the minro comments, then we merge and add a test next. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx !
Cool! merging... |
No description provided.