-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide odd length kernels #343
Provide odd length kernels #343
Conversation
1f3f212
to
89e98aa
Compare
The Travis failure seems unrelated... |
Yes it is unrelated and is also currently breaking #342 |
Yes, this is indeed a separate issue. On #342 it only comes up with the Based on Travis docs (see the section on 'Double builds') it seems to me that the PR check is done on the merge of the PR and the main branch. So maybe something is up with the main branch? Not very sure... |
Is there something preventing this to be merged? |
@man-shu I think it was a Travis issue. I restarted the failed check and it passes now. |
Merging, then ! |
thx to all of you ! |
Great! |
In release 1.6 of Scipy, the function
sepfir2d
only accepts odd length arrays forhrow
andhcol
(see this PR).