-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix failures fields NTRN-359 #335
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quasisamurai
force-pushed
the
fix/failures-fields
branch
4 times, most recently
from
August 9, 2024 09:56
f60893f
to
486f65c
Compare
quasisamurai
force-pushed
the
fix/failures-fields
branch
from
August 9, 2024 13:39
486f65c
to
2ca9126
Compare
quasisamurai
force-pushed
the
fix/failures-fields
branch
from
August 12, 2024 09:49
2ca9126
to
1ab4537
Compare
NeverHappened
previously approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix conflicts, otherwise LGTM
…ields # Conflicts: # package.json # yarn.lock
quasisamurai
dismissed
NeverHappened’s stale review
September 2, 2024 11:53
The base branch was changed.
# Conflicts: # package.json # yarn.lock
NeverHappened
previously approved these changes
Sep 2, 2024
# Conflicts: # src/testcases/run_in_band/interchaintx.test.ts # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TASK