fix failures request in contract manager #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quasisamurai
changed the title
joldie777
previously approved these changes
Aug 13, 2024
NeverHappened
requested changes
Aug 14, 2024
| } | ||
|
|
||
| // QueryFailureRequest is request type for the Query/Failures RPC method. | ||
| message QueryFailureRequest { |
There was a problem hiding this comment.
pagination field seems to be not needed logically (and not used) for QueryFailureRequest.
Please remove it
| @@ -18,7 +18,7 @@ service Query { | |||
| } | |||
|
|
|||
| // Queries a Failure by contract address and failure ID. | |||
| rpc AddressFailure(QueryFailuresRequest) returns (QueryFailuresResponse) { | |||
| rpc AddressFailure(QueryFailureRequest) returns (QueryFailuresResponse) { | |||
There was a problem hiding this comment.
How about making QueryFailureResponse struct without pagination? It seems strange that we return it in array even tho it's always one failure. And pagination always null
|
Also - please attach PR to neutronjs here |
NeverHappened
approved these changes
Sep 2, 2024
pr0n00gler
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TASK
Related PRs