feat: vesting and vault interface #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foxpy
requested changes
Mar 24, 2023
Co-authored-by: Murad <muradkarammaev@gmail.com>
…' into feat/vesting-and-vault-interface
ratik
reviewed
Mar 24, 2023
ratik
reviewed
Mar 24, 2023
Co-authored-by: Sergey R <serg.s.r@gmail.com>
sotnikov-s
reviewed
Mar 27, 2023
sotnikov-s
reviewed
Mar 27, 2023
sotnikov-s
reviewed
Mar 27, 2023
| @@ -0,0 +1,25 @@ | |||
| [package] | |||
| name = "vesting-lp" | |||
There was a problem hiding this comment.
why is it vesting-lp? what does lp mean here?
There was a problem hiding this comment.
Usually lp stands for liquidity provider, but to be honest I don't see anything related to market making in this contract.
foxpy
reviewed
Mar 28, 2023
foxpy
requested changes
Mar 28, 2023
There was a problem hiding this comment.
By the way, make check_contracts fails on this branch with a following error:
artifacts/vesting_lp.wasm: failure
Error compiling Wasm: Could not compile: WebAssembly translation error: Error in middleware Gatekeeper: Float operator detected: F32Load { memarg: MemoryImmediate { align: 2, offset: 0, memory: 0 } }. The use of floats is not supported.
…anager exists before add/remove him
sotnikov-s
reviewed
Mar 28, 2023
* feat: added managed vesting #NTRN-409 * added tests for register_vesting_accounts() * more remove_vesting_accounts() tests, added a VestingState query * added cliff test cases, cargo fmt & cargo clippy * merged base, more clippy fixes * more cargo fmt * restore astroport contracts * 300 -> 400 * fixed #2 scenario comment (300 -> 400) * review fixes
sotnikov-s
reviewed
Mar 29, 2023
sotnikov-s
approved these changes
Mar 29, 2023
oldremez
approved these changes
Mar 29, 2023
| assert_eq!(vesting_res, Uint128::new(0u128)); | ||
| let max_unclaimed_user1: u128 = 200; | ||
| let max_unclaimed_total: u128 = 1200; | ||
| for i in 0..=10 { |
There was a problem hiding this comment.
This logic with loops in tests looks a bit non-obvious to me… Like, I got to think to understand it. It's not a request for change though
foxpy
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemets the besing vesting contract with interface for VotingVault type contract.
The following things have been done during moving contract into new type:
Basic Vesting(
vesting-lp) contract implementation in addition to parent type:UnclaimedAmountAtHeightandUnclaimedTotalAmountAtHeight