Update/update uri #148
Merged
Update/update uri #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: Composer(deps): Bump newfold-labs/wp-module-data from 2.4.7 to 2.4.8
Passing run #397 ↗︎
Details:
Review all test suite changes for PR #148 ↗︎ |
|||||||||||||||
Passing run #398 ↗︎
Details:
Review all test suite changes for PR #148 ↗︎ |
|||||||||||||||
wpscholar
reviewed
Oct 20, 2023
| @@ -10,11 +10,12 @@ | |||
| * @wordpress-plugin | |||
| * Plugin Name: The Web.com Plugin | |||
| * Plugin URI: https://web.com | |||
| * Update URI: https://github.com/newfold-labs/wp-plugin-web/ | |||
There was a problem hiding this comment.
@circlecube Should we update this to be https://github.com/newfold-labs/wp-plugin-web/blob/main/bootstrap.php#L89C19-L89C93?
There was a problem hiding this comment.
I can change these to point to the update uri, but from what reading the doc the url isn't actually used in any way. I figured if a user were to follow the URL having them hit the repo page might be better than the API endpoint which downloads the zip. See: https://make.wordpress.org/core/2021/06/29/introducing-update-uri-plugin-header-in-wordpress-5-8/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRESS1-178