Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/update uri #148

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Update/update uri #148

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5f40a2
update plugin header with update uri, also update tested up to version
circlecube Oct 20, 2023
97b4bbe
Merge branch 'develop' into update/update-uri
circlecube Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion wp-plugin-web.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,12 @@
* @wordpress-plugin
* Plugin Name: The Web.com Plugin
* Plugin URI: https://web.com
* Update URI: https://github.com/newfold-labs/wp-plugin-web/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@circlecube Should we update this to be https://github.com/newfold-labs/wp-plugin-web/blob/main/bootstrap.php#L89C19-L89C93?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can change these to point to the update uri, but from what reading the doc the url isn't actually used in any way. I figured if a user were to follow the URL having them hit the repo page might be better than the API endpoint which downloads the zip. See: https://make.wordpress.org/core/2021/06/29/introducing-update-uri-plugin-header-in-wordpress-5-8/

* Description: WordPress plugin that integrates a WordPress site with the Web.com control panel, including performance, security, and update features.
* Version: 1.3.0
* Requires at least: 4.7
* Requires PHP: 5.6
* Tested up to: 6.3.1
* Tested up to: 6.3.2
* Author: Web.com
* Author URI: https://web.com
* Text Domain: wp-plugin-web
Expand Down
Loading