Obfuscate License Key in Agent Logs #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pete911
reviewed
Aug 18, 2021
v3/newrelic/collector.go
Outdated
| if n := len(licenseKey); n > 4 { | ||
| query.Set("license_key", string(licenseKey[0:2]+".."+licenseKey[n-2:])) | ||
| } else { | ||
| query.Set("license_key", licenseKey) |
There was a problem hiding this comment.
this line (else) is redundant, license key is already set.
There was a problem hiding this comment.
Of course, thanks!
This was referenced Aug 18, 2021
nr-swilloughby
approved these changes
Sep 1, 2021
This was referenced Dec 2, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Security-minded customers have noticed that the Go Agent logs the URL of the agent endpoint at New Relic. This URL includes the customer's license key. This PR removes most of the license key, but keeps the first and last two characters to facilitate troubleshooting.
This work is based on PR #354 submittted by @pete911 . Thanks so much for your contribution!