Logger license #415
Merged
Logger license #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 3.15.0
Release 3.15.1
|
Is it worth considering removing the previous license key redaction on the logic that this change will cover that use case as well, since this one sits at a more generic level (this redacts license keys from any logged message while that previous change was more specific)? |
… earlier redaction code
RichVanderwal
approved these changes
Dec 3, 2021
This was referenced Dec 3, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR adds a filter to messages logged through the go agent's
v3/internal/loggerfacility, for all severity levels, to redact license key information from the message being logged. Since the log message may include the license key embedded in a URL string or other marshalled text, we do not try to limit the filter by parsing the strings. Rather, we simply replace the text "license_key=" followed by a hex digit sequence, such that the hex digits are removed.