[common-library] Add missing features to the common library (NR-281093) #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kang-makes
force-pushed
the
kang-makes/common-library/add-features-for-super-agent
branch
2 times, most recently
from
836cfb5
to
6d2d16e
Compare
kang-makes
force-pushed
the
kang-makes/common-library/add-features-for-super-agent
branch
2 times, most recently
from
2dba97c
to
bb8d73e
Compare
kang-makes
changed the title
sigilioso
reviewed
Aug 14, 2024
kang-makes
force-pushed
the
kang-makes/common-library/add-features-for-super-agent
branch
from
bb8d73e
to
48dd6e3
Compare
kang-makes
force-pushed
the
kang-makes/common-library/add-features-for-super-agent
branch
from
48dd6e3
to
755db55
Compare
3 tasks
kang-makes
force-pushed
the
kang-makes/common-library/add-features-for-super-agent
branch
from
27eb921
to
b750ce2
Compare
sigilioso
reviewed
Aug 23, 2024
kang-makes
force-pushed
the
kang-makes/common-library/add-features-for-super-agent
branch
from
b750ce2
to
15a9b7b
Compare
kang-makes
force-pushed
the
kang-makes/common-library/add-features-for-super-agent
branch
from
0486574
to
15ad3fd
Compare
dbudziwojskiNR
requested changes
Aug 28, 2024
dbudziwojskiNR
approved these changes
Aug 29, 2024
dbudziwojskiNR
deleted the
kang-makes/common-library/add-features-for-super-agent
branch
kang-makes
added a commit
that referenced
this pull request
Sep 23, 2024
#### Is this a new chart No #### What this PR does / why we need it: super-agent chart got the config from a field called `content` that added any arbitrary data to a config map. This is supposed to control this configMap and render it using values from Helm's `values.yaml`. It also adds some protections so a customer is not able to use it on unsupported environments. #### Special notes for your reviewer: This PR is blocked until #1463 is merged. #### Checklist - [x] Chart Version bumped - [x] Variables are documented in the README.md - [x] Title of the PR starts with chart name (e.g. `[mychartname]`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart
No
What this PR does / why we need it:
We thought that some of the features that we need for the super-agent would be awesome to have them at
common-librarylevel.We need the chart to be able to calculate the region (or let the user to specify it) and a new API Key.
Which issue this PR fixes
Special notes for your reviewer:
To read it easier, I would go commit by commit as I added a new feature with its own documentation on each commit.
Checklist
[mychartname])