[super-agent] Improve helm chart UX (NR-281093)

[kang-makes]

Is this a new chart

No

What this PR does / why we need it:

super-agent chart got the config from a field called content that added any arbitrary data to a config map. This is supposed to control this configMap and render it using values from Helm's values.yaml.

It also adds some protections so a customer is not able to use it on unsupported environments.

Special notes for your reviewer:

This PR is blocked until #1463 is merged.

Checklist

• Chart Version bumped
• Variables are documented in the README.md
• Title of the PR starts with chart name (e.g. [mychartname])

[kang-makes]

I had to remove from the chart the test for cluster's Kubernetes version as it was colliding with the CI so I moved it to the PR #1471

[kang-makes]

The upgrade path is failing with this error:

Error: UPGRADE FAILED: template: super-agent/charts/super-agent-deployment/templates/deployment-superagent.yaml:24:34: executing "super-agent/charts/super-agent-deployment/templates/deployment-superagent.yaml" at <include (print $.Template.BasePath "/configmap-superagent-config.yaml") .>: error calling include: template: super-agent/charts/super-agent-deployment/templates/configmap-superagent-config.yaml:12:8: executing "super-agent/charts/super-agent-deployment/templates/configmap-superagent-config.yaml" at <include "newrelic-super-agent.config.content" .>: error calling include: template: super-agent/charts/super-agent-deployment/templates/_helpers.tpl:137:33: executing "newrelic-super-agent.config.content" at <include "newrelic-super-agent.config.agents.yaml" .>: error calling include: template: super-agent/charts/super-agent-deployment/templates/_helpers.tpl:18:8: executing "newrelic-super-agent.config.agents.yaml" at <fail (printf "Agent %s does not have agent type" $subAgentName)>: error calling fail: Agent open-telemetry does not have agent type

The previous values.yaml had this hardcoded: https://github.com/newrelic/helm-charts/pull/1466/files#diff-3bd49393f47bdfcb35b90c33237f384109da730bc892fa317ba8db58d29d7975L149-L158

Now, instead of having it in the values we have it as a helper: https://github.com/newrelic/helm-charts/pull/1466/files#diff-f752c985c9b04f49290d4a210d58d0981e8197c5825b7747defdc701fa4e1652R25-R34

The schema changed from this:

    superAgent:
      content:
        agents:
          open-telemetry:
            agent_type: newrelic/io.opentelemetry.collector:0.2.0
    subAgents:
      open-telemetry:
        content:
          chart_values:
            licenseKey: ${nr-env:NR_LICENSE_KEY}
            cluster: ${nr-env:NR_CLUSTER_NAME}

To this:

    subAgents:
      open-telemetry:
        type: newrelic/io.opentelemetry.collector:0.2.0
        content:
          chart_values:
            licenseKey: ${nr-env:NR_LICENSE_KEY}
            cluster: ${nr-env:NR_CLUSTER_NAME}

So the new chart is complaining that the old chart does not have type on the subagent.

The test is ok to fail as this is a breaking change. It should not have any repercussion to any customer as we do not support upgrades with --reuse-values.

[paologallinaharbur]

I think that this is not clear if you do not know what it is going on

[kang-makes]

This is the clearest way I found to explain it. I am open to any suggestion because it is a weird default.

[paologallinaharbur]

I think that if we say something: "If empty the chart add automatically the newrelic/io.opentelemetry.collector subagent. On the other hand, if populated the list of agent created is the one specified overwriting the default"

[kang-makes]

Done #f11ce5a. Let me know what you think :)

[gsanchezgavier]

I just left nits, feel free to discard them, LGTM thanks!

[gsanchezgavier]

cool thanks!