Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo_deployer): updated specific regex in validate_output's param value #1134

Conversation

rpaliwal1997
Copy link
Contributor

Issue:- Currently in few of the demo deployer scripts, the validation output strings not correct, tests are showing as passed even though they are failing, due to validation output check string is not correctly entered.
Jira Ticket

Updated the validate_output fields in the deployer scripts to use the correct regular expressions for specific agent installations.
Changes done in the variety of deployer scripts for the different agents, for example in PHP deployer scripts.

PHP Deployer Script:
From: "New Relic installation complete"
To: "PHP Agent\s+\(installed\)"

Context
The previous validate_output string, "New Relic installation complete", was too generic and indicated success for any installation. This update ensures that the validate_output specifically checks for the PHP agent installation status.

Verification
Verified that the new regular expression correctly identifies the PHP agent installation.

image

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@shashank-reddy-nr
Copy link
Contributor

Hi @rpaliwal1997 , Validation cheks are failing stating that a PR has to be created from a branch in open-install-library. So, I ask you to raise a new PR without forking from onwards. I see you already have access to open-install-library. So, please use relevant github id and push your new branch and raise a new PR again.

image

@shashank-reddy-nr
Copy link
Contributor

Closing this PR as this is duplicate of this PR: #1135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants