fix(demo_deployer): Updated specific regex in validate_output's param #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:- Currently in few of the demo deployer scripts, the validation output strings not correct, tests are showing as passed even though they are failing, due to validation output check string is not correctly entered.
Jira Ticket
Updated the validate_output fields in the deployer scripts to use the correct regular expressions for specific agent installations.
Changes done in the variety of deployer scripts for the different agents, for example in PHP deployer scripts.
PHP Deployer Script:
From: "New Relic installation complete"
To: "PHP Agent\s+(installed)"
Context
The previous validate_output string, "New Relic installation complete", was too generic and indicated success for any installation. This update ensures that the validate_output specifically checks for the PHP agent installation status.
Verification
Verified that the new regular expression correctly identifies the PHP agent installation.