Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Recreate Synthetics resources on account ID change #2518

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

mbazhlekova
Copy link
Contributor

Description

This PR forces a new Synthetics resource if Account ID is changed

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

How to test this change?

  1. Create a Synthetics monitor in one account
  2. Switch to a different account and change the account ID for the monitor
  3. Apply again

The Synthetics monitor should be deleted from the original account and recreated in the new account.

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (0db566f) 33.83% compared to head (7904555) 35.18%.
Report is 1 commits behind head on main.

Files Patch % Lines
newrelic/resource_newrelic_api_access_key.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2518      +/-   ##
==========================================
+ Coverage   33.83%   35.18%   +1.35%     
==========================================
  Files          91       91              
  Lines       24924    24927       +3     
==========================================
+ Hits         8432     8771     +339     
+ Misses      16336    15954     -382     
- Partials      156      202      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbazhlekova mbazhlekova force-pushed the maria/synthetics-force-new-account-id-change branch from 9251dd0 to 7904555 Compare December 13, 2023 16:31
@mbazhlekova mbazhlekova merged commit b348462 into main Dec 13, 2023
9 checks passed
@mbazhlekova mbazhlekova deleted the maria/synthetics-force-new-account-id-change branch December 13, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants