ci(PPDSC-2017): newskit integration test #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vanals
requested review from
jps,
Xin00163,
pdimova,
baburay23,
mutebg,
evgenitsn and
Srinivasan-Ramasamy
as code owners
|
You can preview these changes on: |
Vanals
added
ready for review
Xin00163
reviewed
May 4, 2022
| echo "Installing needed packages into the NextJS app" | ||
|
|
||
| cd newskit-integration-test | ||
| yalc add newskit |
There was a problem hiding this comment.
Nice. It seems that with yalc add my-package, we don't need yarn link anymore. I assume any local changes in newskit will be reflected in this react app automatically?
There was a problem hiding this comment.
Yeah, I was having some issues when using yarn link. facebook/react#14257.
Only yalc helped me. Not sure if at the end worked cos react needed to be downgraded. Anyway, overall, yalc seem to be better thank yarn link!
Xin00163
previously approved these changes
May 5, 2022
evgenitsn
reviewed
May 9, 2022
Co-authored-by: Evgeni Nikolov <evgeni.nikolov@news.co.uk>
mutebg
previously approved these changes
May 9, 2022
mutebg
changed the title
evgenitsn
previously approved these changes
May 9, 2022
Co-authored-by: James Spencer <james.spencer@news.co.uk>
evgenitsn
approved these changes
May 10, 2022
mutebg
approved these changes
May 10, 2022
Xin00163
pushed a commit
that referenced
this pull request
Oct 17, 2022
* docs(PPDSC-0000): testing permissions * docs(PPDSC-0000): removing test changed from readme * ci(PPDSC-2017): created job and script for integr test * ci(PPDSC-2017): added job in pr workflow * ci(PPDSC-2017): removed yarn build and imrpoved requires * ci(PPDSC-2017): improved comments in template, added back yarn build * ci(PPDSC-2017): updated template * ci(PPDSC-2017): removed index.js * ci(PPDSC-2017): added -p flag in mkdir command * ci(PPDSC-2017): adding caching and fixing last run * ci(PPDSC-2017): fixed chaching and increased v * ci(PPDSC-2017): changing executor and how install cy * ci(PPDSC-2017): added note in MakeFile, updated Cy installation * ci(PPDSC-2017): testing speed with no cache * ci(PPDSC-2017): improved cy config and tests * ci(PPDSC-2017): improve comment in makefile, yalc publish and spec fix * ci(PPDSC-2017): adding test job in workflows * ci(PPDSC-2017): improved naming step * Update Makefile Co-authored-by: Evgeni Nikolov <evgeni.nikolov@news.co.uk> * Update scripts/templates-integration-test/index.txt Co-authored-by: James Spencer <james.spencer@news.co.uk> Co-authored-by: Evgeni Nikolov <evgeni.nikolov@news.co.uk> Co-authored-by: James Spencer <james.spencer@news.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPDSC-2017
What
Created new CircleCi job
test_newskit_in_nextjs_app.It Installs needed packages (yalc, create-next-app, etc.)
Creates the NextJs app
Prepares the NExt App adding files(for cy) and overriding the index.js, also installs other packages.
Once the app is ready, through
start-server-and-testserves the app and tests it using cy.Created folder in
scriptscontaining few template files for this app.Also replicated the issue we released, importing the scenario from the wrong file. The app crashed and the test failed.
it failed even before cy opening the page.
start-server-and-testdoes check already for 200 before testing.@jps
Cy might actually not be needed, BUT is a nice setting and nice to have if we foresee adding CY integration tests in the future. If not
start-server-and-testwill be all we need and we can remove CY reducing the job time by around 1 min.I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: