-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(PPDSC-2017): newskit integration test #183
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
eb7f87f
docs(PPDSC-0000): testing permissions
Vanals 20cf719
docs(PPDSC-0000): removing test changed from readme
Vanals dc4bd3c
docs(PPDSC-0000): removing test changed from readme
Vanals aecea28
chore(PPDSC-2007): rolling back release
Vanals 53afa86
Merge branch 'main' of github.com:newscorp-ghfb/newskit into main
Vanals d6359db
ci(PPDSC-2017): created job and script for integr test
Vanals eac4f43
ci(PPDSC-2017): added job in pr workflow
Vanals ab2434b
ci(PPDSC-2017): removed yarn build and imrpoved requires
Vanals 01b9875
ci(PPDSC-2017): improved comments in template, added back yarn build
Vanals 5d943cd
ci(PPDSC-2017): updated template
Vanals 021583c
chore(PPDSC-2007): test git set identity
Vanals 65ca481
ci(PPDSC-2017): removed index.js
Vanals 896e555
ci(PPDSC-2017): added -p flag in mkdir command
Vanals 4d103e8
ci(PPDSC-2017): adding caching and fixing last run
Vanals 893ec38
ci(PPDSC-2017): fixed chaching and increased v
Vanals 9a2ef8c
ci(PPDSC-2017): changing executor and how install cy
Vanals e5e931b
ci(PPDSC-2017): added note in MakeFile, updated Cy installation
Vanals 6ba447b
ci(PPDSC-2017): testing speed with no cache
Vanals 839812e
ci(PPDSC-2017): improved cy config and tests
Vanals 87e2b56
ci(PPDSC-2017): improve comment in makefile, yalc publish and spec fix
Vanals 6f3b194
ci(PPDSC-2017): adding test job in workflows
Vanals 93d80d5
ci(PPDSC-2017): improved naming step
Vanals a869324
Merge branch 'main' into ci/PPDSC-2017-newskit-integration-test
Vanals 2e3c6df
Update Makefile
Vanals b73524b
Update scripts/templates-integration-test/index.txt
Vanals dda146a
Merge branch 'main' into ci/PPDSC-2017-newskit-integration-test
Vanals File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"baseUrl": "http://localhost:3000", | ||
"video": false | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
// Template for populating the index.js file in the NextJS app; | ||
// built from the `test_newskit_in_nextjs_app` CircleCi job. | ||
|
||
import {ThemeChecker, newskitLightTheme, ThemeProvider} from 'newskit'; | ||
|
||
export default function Home() { | ||
return ( | ||
<ThemeProvider theme={newskitLightTheme}> | ||
<ThemeChecker /> | ||
</ThemeProvider> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
describe('Theme Checker', () => { | ||
it('Visits the home page and expect to find a play pause button', () => { | ||
cy.visit('/'); | ||
cy.get('[data-testid="audio-player-play-button"]'); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. It seems that with
yalc add my-package
, we don't needyarn link
anymore. I assume any local changes in newskit will be reflected in this react app automatically?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was having some issues when using
yarn link
. facebook/react#14257.Only
yalc
helped me. Not sure if at the end worked cos react needed to be downgraded. Anyway, overall, yalc seem to be better thank yarn link!