Delete default type for generic param in CredentialsConfig #2763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning 💡
By setting the default type for generic like
{}
we are blocking the inference of type in credentials as the whole typing is intended to do (I think so).After that change we are able to do the following code in TS with
strict
mode enabled:I'm aware that marking it as
any
is never the best solution as I'm doing in theProvider
type. But it can get any object shape from us in that case I guess.Checklist 🧢
Affected issues 🎟
Don't know if resolves the following issues so they are just marked as affected.
#2701
#2677