-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: strict types #2802
refactor: strict types #2802
Conversation
@balazsorban44, I've got good progress, however there are two outstanding issues, where I'm unsure what to do:
|
|
Codecov Report
@@ Coverage Diff @@
## beta #2802 +/- ##
==========================================
+ Coverage 13.76% 13.87% +0.11%
==========================================
Files 86 86
Lines 1359 1362 +3
Branches 375 376 +1
==========================================
+ Hits 187 189 +2
- Misses 1163 1164 +1
Partials 9 9
Continue to review full report at Codecov.
|
@balazsorban44, feel free to review. :) |
I will 👍 |
@balazsorban44, it's done. I think the converting the providers to TS should be a different PR, this one is already rather large. |
@balazsorban44, since you asked for me to fix the conflicts, when will this be merged? |
* WIP strict types * wip types * wip strict types * More strict typing * Removing strict false Fix last types * Fix typo * Make TS happy * Fix tests * Fixes to types * Make files align with strict mode
Reasoning 💡
Comply with TS strict typing. Very much WIP.
Checklist 🧢
Affected issues 🎟
Partially fixes #2709. TypeScript conversion should be done in a new PR, to keep this PR more concise.