refactor: decouple Next.js from core #2857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balazsorban44
changed the title
Codecov Report
@@ Coverage Diff @@
## beta #2857 +/- ##
==========================================
- Coverage 14.07% 13.38% -0.70%
==========================================
Files 85 86 +1
Lines 1357 1390 +33
Branches 392 400 +8
==========================================
- Hits 191 186 -5
- Misses 1107 1197 +90
+ Partials 59 7 -52
Continue to review full report at Codecov.
|
|
Done, but I will do some cleanup and testing. |
|
🎉 Experimental release published on npm! npm i next-auth@0.0.0-pr.2857.5130374ayarn add next-auth@0.0.0-pr.2857.5130374a |
Conflicts: src/core/lib/oauth/authorization-url.ts src/core/pages/error.tsx src/core/pages/signin.tsx src/core/pages/signout.tsx src/core/pages/verify-request.tsx src/server/lib/oauth/authorization-url.js src/server/pages/error.tsx src/server/pages/signin.tsx src/server/pages/signout.tsx src/server/pages/verify-request.tsx
This was referenced Oct 14, 2021
5 tasks
mnphpexpert
added a commit
to mnphpexpert/next-auth
that referenced
this pull request
Sep 2, 2024
* refactor: decouple Next.js from core (WIP) * refactor: use `base` instead of `baseUrl`+`basePath` * fix: signout route * refactor(ts): convert files to TS * fix: imports * refactor: convert callback route * fix: add `next` files to package * chore(dev): alias npm email * refactor: do not merge req with user options * refactor: rename userOptions to options * refactor: use native `URL` in `parseUrl` * refactor: move Next.js specific code to `next` module * refactor(ts): return `OutgoingResponse` on all routes * fix: change `base` to `url` * feat: introduce `getServerSession` * refactor: move main logic to `handler` file * chore(dev): showcase `getServerSession` * feat: extract `sessionToken` from Authorization header * fix: pass headers to getServerSession * refactor: rename `server` to `core` * refactor: re-export `next-auth/next` in `next-auth` * fix: add `core` to npm package * fix: re-export default method * feat: return `body`+`header` instead of `json`,`text` * feat: pass `NEXTAUTH_URL` as a variable to core * refactor: simplify Next.js wrapper * feat: export `client/_utils` * fix(ts): suppress TS errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a similar API to SvelteKit endpoints (https://kit.svelte.dev/docs#routing-endpoints), we can create pure functions without the need of mutating
reqandresdeeply nested in the core of NextAuth.js.This will open up new possibilities like expanding to other frameworks #2294 and implement methods like
getServerSession#1535Thanks to the TypeScript refactoring of the core I did earlier in #2552, I have so much confidence doing this, it might actually make it into v4 after all...
pages:
routes:
Also, related: #2612, #2433