Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified/shared storage + fields e.g. for guest names #3

Closed
nickvergessen opened this issue May 26, 2020 · 3 comments · Fixed by nextcloud-libraries/nextcloud-auth#666
Assignees
Labels
3. to review Waiting for reviews discussion Being discussed documentation Improvements or additions to documentation

Comments

@nickvergessen
Copy link
Contributor

E.g. guest name was chosen to be localStorage.getItem('nick') in the past and we decided it should e.g. persist over apps, so the same value should be used in Talk, Deck, Text, etc.
Since all apps use a scoped browser storage, we need a fixed scope for shared data like this, so all apps can use the same scope.

Proposal would be server or shared and in there we use nick or guest-name?

After we agreed on this, it should be documented in the readme.

cc @juliushaertl @ChristophWurst

PS: would a getUnscopedItem function make sense, so you don't need 2 stores, one for the guest name and one for your apps data?

@nickvergessen nickvergessen added 1. to develop Accepted and waiting to be taken care of discussion Being discussed documentation Improvements or additions to documentation labels May 26, 2020
@ChristophWurst
Copy link
Contributor

I'm not sure about this. What you are describing is a shared global variable in fact. I do not think we want to embrace this.

Things like these are easy to add but pain to debug and maintain. Can we add that into OCP of server or one of the existing npm packages?

@rullzer
Copy link

rullzer commented May 27, 2020

I tend to agree with @ChristophWurst here.
I mean a dedicated npm package would make sense I guess. This can of course in the background use this browser-storage. But the logic should be hidden

'getGuestName' 'setGuestName' or something like that is enough.
Then everybody can use it. But it doesn't do 💥 so easily. And we can have proper debugigng and tracing in that package.

@nickvergessen
Copy link
Contributor Author

Okay, then let's do that instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews discussion Being discussed documentation Improvements or additions to documentation
Projects
None yet
4 participants