feat: add guest nickname handling #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
ChristophWurst,
susnux,
juliushaertl,
ShGKme and
Antreesy
susnux
reviewed
Jul 18, 2024
skjnldsv
force-pushed
the
feat/shared-nick
branch
from
f0520ce
to
ef2b2bb
Compare
skjnldsv
force-pushed
the
feat/shared-nick
branch
from
ef2b2bb
to
55fd955
Compare
ShGKme
approved these changes
Jul 18, 2024
|
Thanks for moving it here 💙 |
ShGKme
reviewed
Jul 18, 2024
ChristophWurst
approved these changes
Jul 18, 2024
skjnldsv
force-pushed
the
feat/shared-nick
branch
from
55fd955
to
137af0e
Compare
susnux
approved these changes
Jul 18, 2024
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
feat/shared-nick
branch
from
137af0e
to
a43ebbf
Compare
This was referenced Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix nextcloud/server#17147
Fix nextcloud-libraries/nextcloud-browser-storage#3
Followup from nextcloud-libraries/nextcloud-sharing#33