Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global guest name setting #17147

Closed
juliushaertl opened this issue Sep 15, 2019 · 5 comments · Fixed by nextcloud-libraries/nextcloud-auth#666
Closed

Global guest name setting #17147

juliushaertl opened this issue Sep 15, 2019 · 5 comments · Fixed by nextcloud-libraries/nextcloud-auth#666

Comments

@juliushaertl
Copy link
Member

Since more and more apps allow users without an account to set a guest name if they use a public sharing link, we should provide a server api to properly store the name so that all apps (talk, text, onlyoffice, collabora) can use it.

For live updating open sessions with the new name we could use the local storage onChanged event.

For the backend I would propose to have a similar interface to IUserSession e.b. IGuestSession. It might make sense to have a dedicated unique id in case apps store additional information for the guest user, so a user name change will not lead to issues.

cc @nickvergessen

@jancborchardt Maybe we should also discuss some more unified way of setting the guest user? Super quick mockup just for the positioning:
image

@juliushaertl
Copy link
Member Author

Maybe it should also handle guest avatars as in nextcloud/spreed#357

@nickvergessen
Copy link
Member

Yeah, as long as updating the name goes to a central location and triggers an event as well, so apps like talk can listen to it and update the database it sounds good to me.

@nickvergessen nickvergessen added enhancement technical debt 1. to develop Accepted and waiting to be taken care of feature: users and groups and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Sep 24, 2019
@05nelsonm

This comment has been minimized.

@jancborchardt

This comment has been minimized.

@joshtrichards
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment