Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @nextcloud/vue-select #3703

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Use @nextcloud/vue-select #3703

merged 1 commit into from
Feb 1, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Feb 1, 2023

Switch to @nextcloud/vue-select from vue-select with accessibiity improvements and bug fixes, see https://github.com/nextcloud-deps/vue-select/releases

@Pytal
Use @nextcloud/vue-select
edef693 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added bug Something isn't working 3. to review Waiting for reviews feature: select Related to the NcSelect* components dependencies Pull requests that update a dependency file accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Feb 1, 2023
@Pytal Pytal added this to the 7.6.0 milestone Feb 1, 2023
@Pytal Pytal self-assigned this Feb 1, 2023
@JuliaKirschenheuter
Copy link
Contributor

Switch to @nextcloud/vue-select from vue-select with accessibiity improvements and bug fixes, see https://github.com/nextcloud-deps/vue-select/releases

a new fork, right?

@Pytal
Copy link
Contributor Author

Pytal commented Feb 1, 2023

a new fork, right?

Precisely :)

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 1, 2023
@Pytal Pytal merged commit c80a585 into master Feb 1, 2023
@Pytal Pytal deleted the enh/a11y-nc-vue-select branch February 1, 2023 18:59
@Pytal Pytal mentioned this pull request Feb 2, 2023
Closed
11 tasks
@Pytal Pytal mentioned this pull request Feb 16, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@susnux susnux susnux approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working dependencies Pull requests that update a dependency file feature: select Related to the NcSelect* components
Projects
None yet
Milestone
7.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @JuliaKirschenheuter @susnux @skjnldsv