Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @nextcloud/vue from 7.5.0 to 7.6.0 #36739

Closed
wants to merge 2 commits into from

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Feb 16, 2023

Summary

Bump @nextcloud/vue from https://github.com/nextcloud/nextcloud-vue/releases/tag/v7.5.0 to https://github.com/nextcloud/nextcloud-vue/releases/tag/v7.6.0

Requires

Checklist

@Pytal Pytal added this to the Nextcloud 26 milestone Feb 16, 2023
@Pytal Pytal self-assigned this Feb 16, 2023
@Pytal
Copy link
Member Author

Pytal commented Feb 16, 2023

/backport to stable25

@Pytal
Copy link
Member Author

Pytal commented Feb 16, 2023

Seems to break script load order with many OC is not defined errors, there is also an

Uncaught ReferenceError: exports is not defined
    at ./node_modules/@nextcloud/dialogs/dist/index.js

error which is probably related to the recent https://github.com/nextcloud/nextcloud-dialogs/releases/tag/v4.0.0 release and may be similar to nextcloud-libraries/nextcloud-vue#3753 though resolve.fullySpecified = false here doesn't seem to fix it

Any ideas @juliushaertl?

@juliusknorr
Copy link
Member

Was fixed in nextcloud-libraries/nextcloud-dialogs#761, bumping @nextcloud/dialogs to 4.0.1 should resolve this

Base automatically changed from deps/nextcloud/password-confirmation-4.0.4 to master February 17, 2023 01:46
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the deps/nextcloud/vue-7.6.0 branch from 831143c to dc5b585 Compare February 17, 2023 02:57
@Pytal Pytal changed the base branch from master to deps/nextcloud/dialogs-4.0.1 February 17, 2023 02:58
@Pytal
Copy link
Member Author

Pytal commented Feb 17, 2023

Was fixed in nextcloud/nextcloud-dialogs#761, bumping @nextcloud/dialogs to 4.0.1 should resolve this

The

Uncaught ReferenceError: exports is not defined
    at ./node_modules/@nextcloud/dialogs/dist/index.js

error is resolved on top of #36757 but the OC is not defined errors still persist

@Pytal Pytal marked this pull request as draft February 17, 2023 03:01
@Pytal Pytal force-pushed the deps/nextcloud/dialogs-4.0.1 branch from 56bd646 to 4082d90 Compare February 22, 2023 03:27
@Pytal
Copy link
Member Author

Pytal commented Feb 23, 2023

Superseded by #36813

@Pytal Pytal closed this Feb 23, 2023
@Pytal Pytal deleted the deps/nextcloud/vue-7.6.0 branch February 24, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants