Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @nextcloud/vue from 7.5.0 to 7.7.0 and add node-polyfill-webpack-plugin #36813

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Feb 23, 2023

Summary

Bump @nextcloud/vue from https://github.com/nextcloud/nextcloud-vue/releases/tag/v7.5.0 to https://github.com/nextcloud/nextcloud-vue/releases/tag/v7.7.0

Add https://github.com/Richienb/node-polyfill-webpack-plugin to fix the process is not defined and resulting OC is not defined errors

Checklist

@Pytal Pytal added 3. to review Waiting for reviews dependencies labels Feb 23, 2023
@Pytal Pytal added this to the Nextcloud 26 milestone Feb 23, 2023
@Pytal Pytal self-assigned this Feb 23, 2023
@Pytal
Copy link
Member Author

Pytal commented Feb 23, 2023

/backport to stable25

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@artonge
Copy link
Contributor

artonge commented Feb 23, 2023

Shouldn't the process thing be solved on the @nextcloud/files side ? I never really played with modules, so I have no idea.

webpack.common.js Outdated Show resolved Hide resolved
@nickvergessen

This comment was marked as resolved.

@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
- Add node-polyfill-webpack-plugin to polyfill Node.js core modules

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the deps/nextcloud/vue-7.7.0 branch from 671d62c to 1257107 Compare February 23, 2023 19:56
@Pytal
Copy link
Member Author

Pytal commented Feb 23, 2023

Shouldn't the process thing be solved on the @nextcloud/files side ? I never really played with modules, so I have no idea.

@nextcloud/files (https://github.com/nextcloud/nextcloud-files/blob/94bfe0e1a093dcb8ed6b0710e7bdd8214ba16427/lib/files/node.ts#L22) seems to have an implicit dependency on running within a https://github.com/nextcloud/server runtime environment as it neither has a path dependency in package.json nor a polyfill for it in https://github.com/nextcloud/nextcloud-files/blob/94bfe0e1a093dcb8ed6b0710e7bdd8214ba16427/rollup.config.js while the server package.json does

From the process is not defined error stack trace we see that the path import is resolved to https://github.com/jinder/path which is also used in https://github.com/nextcloud/server

import { normalize } from 'path'

For these reasons let's handle the dependencies and polyfills here for now, while explicit dependencies and polyfills may be added to https://github.com/nextcloud/nextcloud-files separately if needed

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 23, 2023
@Pytal Pytal merged commit abaf6cd into master Feb 23, 2023
@Pytal Pytal deleted the deps/nextcloud/vue-7.7.0 branch February 23, 2023 20:56
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Feb 23, 2023

The backport to stable25 failed. Please do this backport manually.

#36841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants