Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] Bump @nextcloud/vue from 7.5.0 to 7.7.0 and add node-polyfill-webpack-plugin #36841

Merged
merged 1 commit into from
Feb 28, 2023
Merged

[stable25] Bump @nextcloud/vue from 7.5.0 to 7.7.0 and add node-polyfill-webpack-plugin #36841

merged 1 commit into from
Feb 28, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Feb 24, 2023

Summary

Backport #36813

Checklist

@Pytal Pytal added 3. to review Waiting for reviews dependencies labels Feb 24, 2023
@Pytal Pytal added this to the Nextcloud 25.0.5 milestone Feb 24, 2023
@Pytal Pytal self-assigned this Feb 24, 2023
@Pytal Pytal mentioned this pull request Feb 24, 2023
Merged
4 tasks
@nickvergessen nickvergessen removed their request for review February 24, 2023 05:20
@Pytal Pytal mentioned this pull request Feb 24, 2023
Merged
5 tasks
@JuliaKirschenheuter
Copy link
Contributor

@Pytal why do we need NodePolyfillPlugin now?

@Pytal
Copy link
Member Author

Pytal commented Feb 28, 2023

@Pytal why do we need NodePolyfillPlugin now?

This would be for resolving the runtime errors which prevented anything but the base PHP template from loading described in the original PR #36813 :)

@Pytal Pytal mentioned this pull request Feb 28, 2023
Merged
4 tasks
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the backport/36813/stable25 branch 2 times, most recently from 8c7d3d5 to adc6ccf Compare February 28, 2023 10:53
@Pytal @JuliaKirschenheuter
Bump @nextcloud/vue from 7.5.0 to 7.7.0
0c651aa 
- Add node-polyfill-webpack-plugin to polyfill Node.js core modules

Signed-off-by: Christopher Ng <chrng8@gmail.com>
(cherry picked from commit 1257107)
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Feb 28, 2023
@JuliaKirschenheuter JuliaKirschenheuter merged commit 72c7c57 into stable25 Feb 28, 2023
@JuliaKirschenheuter JuliaKirschenheuter deleted the backport/36813/stable25 branch February 28, 2023 14:43
This was referenced Feb 28, 2023
Closed
Closed
Closed
Closed
@blizzz blizzz mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

@Pytal Pytal

Labels
3. to review Waiting for reviews dependencies
Projects
None yet
Milestone
Nextcloud 25.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@Pytal @JuliaKirschenheuter @artonge