Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable wrap on overflow #3996

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Disable wrap on overflow #3996

merged 1 commit into from
Apr 24, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Apr 21, 2023

Before After
image image

Keep the input and selected option on a single line

@Pytal
Disable wrap on overflow
93f9ab7 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added bug Something isn't working 3. to review Waiting for reviews feature: select Related to the NcSelect* components labels Apr 21, 2023
@Pytal Pytal added this to the 7.10.1 milestone Apr 21, 2023
@Pytal Pytal self-assigned this Apr 21, 2023
@Pytal Pytal mentioned this pull request Apr 21, 2023
Closed
4 tasks
szaimen
szaimen approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

Jerome-Herbinet
Jerome-Herbinet approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@Jerome-Herbinet Jerome-Herbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Tested on both Firefox and Chromium.

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 24, 2023
@Pytal Pytal merged commit c140b20 into master Apr 24, 2023
@Pytal Pytal deleted the fix/select-wrap branch April 24, 2023 22:36
@raimund-schluessler raimund-schluessler modified the milestones: 7.10.1, 7.11.0 May 3, 2023
@artonge artonge mentioned this pull request May 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@Jerome-Herbinet Jerome-Herbinet Jerome-Herbinet approved these changes

@szaimen szaimen szaimen approved these changes

@susnux susnux Awaiting requested review from susnux

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working feature: select Related to the NcSelect* components
Projects
None yet
Milestone
7.11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Pytal @artonge @Jerome-Herbinet @szaimen @raimund-schluessler