Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profile visibilty dropdowns #37819

Closed
wants to merge 2 commits into from

Conversation

Jerome-Herbinet
Copy link
Member

@Jerome-Herbinet Jerome-Herbinet commented Apr 19, 2023

Signed-off-by: Jérôme Herbinet 33763786+Jerome-Herbinet@users.noreply.github.com

Before :

2023-04-19_14-05

After :

2023-04-19_14-05_1
2023-04-19_14-07

Checklist

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@szaimen szaimen added this to the Nextcloud 27 milestone Apr 19, 2023
@szaimen szaimen added the 3. to review Waiting for reviews label Apr 19, 2023
@szaimen szaimen requested review from a team, artonge and szaimen and removed request for a team April 19, 2023 12:43
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come they were bigger?
Review from @Pytal needed as he is the current expert :)

@Pytal
Copy link
Member

Pytal commented Apr 19, 2023

Thanks @Jerome-Herbinet!

I think we could fix this in a better way, will look into this :)

@Pytal
Copy link
Member

Pytal commented Apr 21, 2023

Fixed upstream in nextcloud-libraries/nextcloud-vue#3996

@Jerome-Herbinet
Copy link
Member Author

Fixed upstream in nextcloud/nextcloud-vue#3996

OK, great !
So I close my PR :-)

@Jerome-Herbinet Jerome-Herbinet deleted the Jerome-Herbinet-profile-patch-1 branch August 31, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants