enh: added option to render icon and text for breadcrumb

[emoral435]

For nextcloud/server#43604

🖼️ Screenshots

🏡 After

Summary

• To prevent a breaking change, I decided to add a prop that user configures to enable the nationality to add text to accompany a icon breadcrumb that is a NcButton, and not an NcAction.
• Since default for iconText is false, all previous library users of NcBreadcrumb will not have breaking changes
• Library now allows user to have NcButton with just text, just icon, and now icon and text

🏁 Checklist

• ⛑️ Tests are included or are not applicable
• 📘 Component documentation has been extended, updated or is not applicable

[raimund-schluessler]

These changes have a logic flaw and lead to the name being always shown.

[emoral435]

@raimund-schluessler I agree with your requested changes. In order to simplify the logic, whilst not making any breaking changes, here are the logic design choices I made:

• First check if icon or iconSlot is passed, and there is no default slot being passed in
  • If so, load icon, then check to see if we want to load accompanying text
• If neither icon nor default slot is passed, then we need to have a fail safe. This fail safe is loading in the name text
• If default slot IS given, then the same logic as previous commits is used

Does this align with your requested changes?

[raimund-schluessler]

Does this align with your requested changes?

Your changes lead to the desired outcome, but they are quite a bit more complicated then they need to be (especially the duplication of NcButton). I pushed a commit to show what i meant.

[emoral435]

bit more complicated then they need to be

Ah, I see what you mean. I saw this problem while developing and I like this solution, but I have a question.

<NcButton v-if="(name || icon || $slots.icon) && !$slots.default"

name prop is required. So unless users explicitly put "", the check will never check if the icon prop or icon slot is inputted. From what I gathered, the checks in place where to always at least have some information shown in the button.
This new change means that if no default slot was input, but also no icon prop or icon slot, then the button will just be empty, no?

[raimund-schluessler]

Without icon, icon slot and default slot, we still show the name. But yes, if that is also empty, nothing will be shown, because nothing was provided. I don't think that is an issue. NcButton works the same.

Addressed

[raimund-schluessler]

/backport to next