Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh: breadcrumbs icons are now more visually descriptive #43604

Merged
merged 3 commits into from
Feb 16, 2024
Merged

enh: breadcrumbs icons are now more visually descriptive #43604

merged 3 commits into from
Feb 16, 2024

Conversation

emoral435
Copy link
Contributor

@emoral435 emoral435 commented Feb 15, 2024 •
edited
Loading

Summary

  • Changed the name path to be something more descriptive for the "/" path, such as the view name
  • All base path urls "/". now are accompanied with descriptive text. perhaps aria-description is no longer needed?

🏡 After

firefox_FroddX5muA

Checklist

@emoral435 emoral435 added enhancement design Design, UI, UX, etc. 3. to review Waiting for reviews labels Feb 15, 2024
@emoral435 emoral435 added this to the Nextcloud 29 milestone Feb 15, 2024
@emoral435 emoral435 self-assigned this Feb 15, 2024
@emoral435 emoral435 mentioned this pull request Feb 15, 2024
Merged
2 tasks
@emoral435 emoral435 mentioned this pull request Feb 15, 2024
Merged
@emoral435 emoral435 force-pushed the enh/breadcrumbs/43569/apply-breadcrumbs-logic-from-personal-files-to-all-files-view branch 2 times, most recently from d4baf28 to 3bd5995 Compare February 15, 2024 15:37
@emoral435 emoral435 force-pushed the enh/breadcrumbs/43569/apply-breadcrumbs-logic-from-personal-files-to-all-files-view branch from 3bd5995 to 775c89f Compare February 16, 2024 01:49
@emoral435 emoral435 force-pushed the enh/breadcrumbs/43569/apply-breadcrumbs-logic-from-personal-files-to-all-files-view branch from 775c89f to 98b41e8 Compare February 16, 2024 01:50
skjnldsv

This comment was marked as resolved.

Sign in to view

@emoral435
Copy link
Contributor Author

firefox_GwmTNd6Mwx

I think this looks much cleaner now, good suggestion!

@emoral435
enh: breadcrumbs icons are now more visually descriptive
bbf279f 
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
@emoral435 emoral435 force-pushed the enh/breadcrumbs/43569/apply-breadcrumbs-logic-from-personal-files-to-all-files-view branch from 98b41e8 to 95bc90e Compare February 16, 2024 14:33
@szaimen
Copy link
Contributor

szaimen commented Feb 16, 2024

I think this looks much cleaner now, good suggestion!

Agreed 🤩

@skjnldsv

This comment was marked as resolved.

Sign in to view
@nextcloud nextcloud deleted a comment from emoral435 Feb 16, 2024
@emoral435
enh: breadcrumb icon matches nav view icon
19619f5 
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
@emoral435 emoral435 force-pushed the enh/breadcrumbs/43569/apply-breadcrumbs-logic-from-personal-files-to-all-files-view branch from 95bc90e to 19619f5 Compare February 16, 2024 15:11
szaimen
szaimen approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from design perspective :)

@skjnldsv
Copy link
Member

/compile

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 16, 2024
@nextcloud-command
chore(assets): Recompile assets
e7bd9f0 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv merged commit 448a40b into master Feb 16, 2024
97 checks passed
@skjnldsv skjnldsv deleted the enh/breadcrumbs/43569/apply-breadcrumbs-logic-from-personal-files-to-all-files-view branch February 16, 2024 16:08
@skjnldsv
Copy link
Member

/backport to stable28

@backportbot backportbot

This comment was marked as resolved.

Sign in to view
@skjnldsv

This comment was marked as resolved.

Sign in to view
@skjnldsv
Copy link
Member

/backport to stable28

@backportbot backportbot bot mentioned this pull request Feb 16, 2024
Merged
2 tasks
@emoral435 emoral435 mentioned this pull request Feb 16, 2024
Closed
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@emoral435 emoral435

Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. enhancement
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

Apply Breadcrumb Logic from "Personal files" to all Files views
5 participants
@emoral435 @szaimen @skjnldsv @ShGKme @nextcloud-command