Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcRichText): include all label items #5455

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Apr 5, 2024

☑️ Resolves

Breaking change:

event 'interact:todo' now returns a string (id of the affected checkbox) instead of an object.

  • Checkbox includes different elements in its label
  • Added explicit indentation for nested lists
  • Interactivity: used the DOM to calculate the position of the element and then use it in the string

🖼️ Screenshots

🏚️ Before 🏡 After
image image

image

Interactivity:

Recording.2024-04-08.102641.mp4

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@DorraJaouad DorraJaouad added the bug Something isn't working label Apr 5, 2024
@DorraJaouad DorraJaouad self-assigned this Apr 5, 2024
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works much better than before, but sub-lists are still a little bit broken

Before After
image image
## Test

List:
- List1
  - Sub item 1
- List 2
  - Sub item 2

Tasks:
- [ ] Task 1
- [ ] @"Test Offline" **open** [web-page](https://nextcloud.com) 
  - [ ] One
  - [ ] Two

src/components/NcRichText/NcRichText.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments. Good workaround with handling the correct line!

P.S. I'd also suggest to enable extended markdown in Usage with NcRichContenteditable example, for checking mention parsing

src/components/NcRichText/NcRichText.vue Show resolved Hide resolved
src/components/NcRichText/NcRichText.vue Outdated Show resolved Hide resolved
src/components/NcRichText/NcRichText.vue Outdated Show resolved Hide resolved
src/components/NcRichText/NcRichText.vue Outdated Show resolved Hide resolved
src/components/NcRichText/NcRichText.vue Outdated Show resolved Hide resolved
@Antreesy Antreesy added this to the 8.11.2 milestone Apr 8, 2024
@Antreesy Antreesy added 3. to review Waiting for reviews feature: richtext Related to the richtext component labels Apr 8, 2024
@Antreesy Antreesy requested a review from ShGKme April 8, 2024 13:33
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad merged commit a2f4617 into master Apr 9, 2024
18 checks passed
@DorraJaouad DorraJaouad deleted the fix/noid/checkbox-label branch April 9, 2024 11:28
@Antreesy Antreesy mentioned this pull request Apr 9, 2024
@susnux
Copy link
Contributor

susnux commented Apr 9, 2024

/backport to next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: richtext Related to the richtext component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mentions are broken in "todo lists" with github markdown patch
4 participants