Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] fix(NcRichText): include all label items #5471

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Apr 9, 2024

Backport of #5455

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews feature: richtext Related to the richtext component labels Apr 9, 2024
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the backport/5455/next branch 2 times, most recently from 1f21846 to 8a31636 Compare April 11, 2024 09:34
@DorraJaouad DorraJaouad marked this pull request as ready for review April 11, 2024 09:34
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks OK (if you tested it)

src/components/NcRichText/NcRichText.vue Show resolved Hide resolved
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

@susnux susnux merged commit 783e413 into next Apr 11, 2024
17 checks passed
@susnux susnux deleted the backport/5455/next branch April 11, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: richtext Related to the richtext component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants