-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NcSelect: make same height and color as NcTextField #5829
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @GVodyanov, the height of these elements needs to be --default-clickable-area, the input fields will also shrink a bit soon
That's what it already should be set to actually @marcoambrosini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The color changes should only be applied to the placeholder, not the input element as the input text must stay main text color.
I made the height of everything |
3f659f2
to
c7d879e
Compare
Signed-off-by: Grigory V <scratchx@gmx.com>
c7d879e
to
02a20a4
Compare
Please remember to add correct labels:
Also always remember to backport to next (there is a TODO section in the PR template for this :) ). |
/backport to next |
@@ -1263,12 +1269,13 @@ body { | |||
|
|||
.vs__selected-options { | |||
// If search is hidden, ensure that the height of the search is the same | |||
min-height: 40px; // 36px search height + 4px search margin | |||
min-height: var(--default-clickable-area); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is #5883
☑️ Resolves
🖼️ Screenshots