Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcSelect): Ensure component height is same as input element #5883

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 29, 2024

☑️ Resolves

Currently the element was 36px instead of 34px which looks weird if using multiple input elements side by side (caused by search input being 34px + 2px border).
Also there was jumping because there are two different border width, so we need to adjust the input height based on the outer border width and the margin of the selected options.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

…r NcSelect with users

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews feature: select Related to the NcSelect* components labels Jul 29, 2024
@susnux susnux added this to the 8.15.2 milestone Jul 29, 2024
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@GVodyanov
Copy link
Contributor

Is it supposed to be 44px though? Because that is what I'm seeing. Why that number?

@susnux
Copy link
Contributor Author

susnux commented Jul 30, 2024

Is it supposed to be 44px though? Because that is what I'm seeing. Why that number?

Where do you see that number? It should be always --default-clickable-area, so:
On Nextcloud 28 and 29 it should be 44px and on Nextcloud 30 it should be 34px.

@GVodyanov
Copy link
Contributor

Is it supposed to be 44px though? Because that is what I'm seeing. Why that number?

Where do you see that number? It should be always --default-clickable-area, so: On Nextcloud 28 and 29 it should be 44px and on Nextcloud 30 it should be 34px.

Ok yeah my bad, tested it on 30 and looks good. But we will have to update some styling in calendar @ChristophWurst as it breaks

@marcoambrosini marcoambrosini merged commit f0bcc65 into master Aug 1, 2024
19 checks passed
@marcoambrosini marcoambrosini deleted the fix/nc-select-size branch August 1, 2024 11:58
@susnux
Copy link
Contributor Author

susnux commented Aug 1, 2024

/backport to next

@ShGKme
Copy link
Contributor

ShGKme commented Aug 20, 2024

Seem now to become an issue on 28/29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: select Related to the NcSelect* components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants