Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to vue 3 #24

Closed
wants to merge 5 commits into from
Closed

chore: migrate to vue 3 #24

wants to merge 5 commits into from

Conversation

raimund-schluessler
Copy link
Collaborator

@raimund-schluessler raimund-schluessler commented Sep 30, 2023

This migrates the package to vue 3. It basically pulls in the beta branch from https://github.com/sagalbot/vue-select/tree/beta onto our adjustments. However, I did that manually and fixed some issues along the way.
I did not really care to adjust the docs, but the component itself and the tests work fine.
Also, I don't have yarn, so someone who has it installed needs to create the yarn.lock file. Or we just migrate to npm, which might be better anyway.

I tested the library in the nextcloud/vue docs vue 3 branch, and it works just fine as far as I can tell.

Of course, we wouldn't merge into master yet, but since I don't have the appropriate rights here, I couldn't create any branch here.

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@GretaD
Copy link

GretaD commented Oct 2, 2023

+1 to migrate to npm

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@Pytal
Copy link
Collaborator

Pytal commented Oct 3, 2023

Rights granted @raimund-schluessler :)

@Pytal
Copy link
Collaborator

Pytal commented Oct 4, 2023

Also might make sense to use something like https://github.com/vueuse/vue-demi for single branch maintenance

@raimund-schluessler
Copy link
Collaborator Author

Also might make sense to use something like https://github.com/vueuse/vue-demi for single branch maintenance

Not sure about this. Vue 2 will be EOL in 3 months, so the better solution is to migrate to Vue 3 and drop support for 2 completely, I think.

@raimund-schluessler
Copy link
Collaborator Author

Rights granted @raimund-schluessler :)

Thanks. How should we proceed here? Should I create a next branch from master and create a PR against it, as we do it in the nextcloud/vue repo?

@Pytal
Copy link
Collaborator

Pytal commented Oct 6, 2023

Thanks. How should we proceed here? Should I create a next branch from master and create a PR against it, as we do it in the nextcloud/vue repo?

Precisely :)

@raimund-schluessler
Copy link
Collaborator Author

Closed in favor of #25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants