-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to vue 3 #24
chore: migrate to vue 3 #24
Conversation
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
+1 to migrate to npm |
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Rights granted @raimund-schluessler :) |
Also might make sense to use something like https://github.com/vueuse/vue-demi for single branch maintenance |
Not sure about this. Vue 2 will be EOL in 3 months, so the better solution is to migrate to Vue 3 and drop support for 2 completely, I think. |
Thanks. How should we proceed here? Should I create a |
Precisely :) |
Closed in favor of #25. |
This migrates the package to vue 3. It basically pulls in the
beta
branch from https://github.com/sagalbot/vue-select/tree/beta onto our adjustments. However, I did that manually and fixed some issues along the way.I did not really care to adjust the docs, but the component itself and the tests work fine.
Also, I don't have
yarn
, so someone who has it installed needs to create theyarn.lock
file. Or we just migrate tonpm
, which might be better anyway.I tested the library in the
nextcloud/vue
docs vue 3 branch, and it works just fine as far as I can tell.Of course, we wouldn't merge into
master
yet, but since I don't have the appropriate rights here, I couldn't create any branch here.