chore: migrate to vue 3 #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Open
raimund-schluessler
requested review from
Pytal,
ChristophWurst and
juliusknorr
Any chance to just upstream those changes and rather use the upstream beta then? |
I don't think so. We couldn't even upstream our changes to the master branch and upstream hasn't seen any activity in nearly 10 months. |
Yes upstream seems to be orphaned, currently we are the most active fork. |
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
fix(ci): Update runners
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
feat(Select): Allow to customize `aria-label` for l10n
- Move accessibility attributes from wrapper to input - Move uid from dropdown toggle element id to wrapper - Wrap open indicator icon with button element - Handle toggle dropdown on selected options to not conflict with open indicator button - Label listbox element Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
enh(a11y): Improve accessibility with correct attributes
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Automate release
- Run `npm pkg fix` Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
chore: Fix repo url
chore: Prefix uid with hyphen
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the package to vue 3. It basically pulls in the beta branch from https://github.com/sagalbot/vue-select/tree/beta onto our adjustments. However, I did that manually and fixed some issues along the way.
The component and the tests work fine. I did not migrate the docs yet and they don't build, if we intend to migrate them at all, I would like to do this in a follow-up PR, since this one is already huge.
I also migrated from
yarntonpm.I tested the library in the
nextcloud/vuedocs vue 3 branch, and it works just fine as far as I can tell.Changes done:
yarntonpm@nextcloud/eslint-config