Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specify a config prefix for another database connection #722

Merged
merged 3 commits into from
Feb 11, 2022
Merged

Allow specify a config prefix for another database connection #722

merged 3 commits into from
Feb 11, 2022

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 2, 2022 •
edited
Loading

@nickvergessen nickvergessen added this to the Nextcloud 24 milestone Feb 2, 2022
@nickvergessen nickvergessen mentioned this pull request Feb 2, 2022
Closed
3 tasks
@nickvergessen nickvergessen force-pushed the techdebt/noid/allow-spliting-activities-to-another-database branch from 9a190b3 to 96857c3 Compare February 2, 2022 15:38
@nickvergessen nickvergessen mentioned this pull request Feb 3, 2022
Merged
@nickvergessen nickvergessen marked this pull request as ready for review February 3, 2022 16:19
@PVince81
Copy link
Member

PVince81 commented Feb 7, 2022

server PR is merged, please adjust CI :-)

@nickvergessen nickvergessen force-pushed the techdebt/noid/allow-spliting-activities-to-another-database branch from 56e0345 to b10c4f6 Compare February 7, 2022 14:46
@PVince81
Copy link
Member

please resolve conflicts

@nickvergessen
Allow splitting activities to another database
4753f83 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fall back to the normal DB when nothing is special
69537e3 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the techdebt/noid/allow-spliting-activities-to-another-database branch from d1c14bb to 69537e3 Compare February 11, 2022 09:31
@nickvergessen
Copy link
Member Author

Ready to review

PVince81
PVince81 approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

there's static code checks, fix or ignore ?

@nickvergessen
Ignore psalm in this cases
d72646d 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@PVince81 PVince81 merged commit d8e11a7 into master Feb 11, 2022
@delete-merged-branch delete-merged-branch bot deleted the techdebt/noid/allow-spliting-activities-to-another-database branch February 11, 2022 14:06
@nickvergessen
Copy link
Member Author

/backport to stable23

@nickvergessen
Copy link
Member Author

/backport to stable22

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 18, 2022
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 18, 2022
Merged
This was referenced Feb 22, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
3. to review enhancement technical debt
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.

Activity in extra database
2 participants
@nickvergessen @PVince81