Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable23] Allow specify a config prefix for another database connection #735

Merged
merged 3 commits into from
Feb 22, 2022
Merged

[stable23] Allow specify a config prefix for another database connection #735

merged 3 commits into from
Feb 22, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Feb 18, 2022 •
edited by nickvergessen
Loading

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #722

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 23.0.3 milestone Feb 18, 2022
@nickvergessen
Allow splitting activities to another database
9b93834 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fall back to the normal DB when nothing is special
3196583 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Ignore psalm in this cases
49eccb4 
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
nickvergessen approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed missing imports and tested it

@artonge
Copy link
Collaborator

artonge commented Feb 22, 2022

Static analysis too:

 ERROR: UndefinedClass - lib/FilesHooks.php:680:56 - Class, interface or enum named OCA\Files_Sharing\External\Storage does not exist (see https://psalm.dev/019)
			if ($owner !== null && !$storage->instanceOfStorage('OCA\Files_Sharing\External\Storage')) {


ERROR: UndefinedClass - lib/FilesHooks.php:1133:36 - Class, interface or enum named OCA\Files_Sharing\SharedStorage does not exist (see https://psalm.dev/019)
		if (!$storage->instanceOfStorage('OCA\Files_Sharing\SharedStorage')) {

@nickvergessen nickvergessen merged commit f776194 into stable23 Feb 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the backport/722/stable23 branch February 22, 2022 12:24
@blizzz blizzz mentioned this pull request Mar 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@artonge artonge artonge approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees
No one assigned
Labels
3. to review enhancement technical debt
Projects
None yet
Milestone
Nextcloud 23.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@artonge @nickvergessen