Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-2.7] Use UTF-8 encoding for OkHttp credentials if available (sdk > 19) #729

Merged
merged 3 commits into from
Oct 18, 2021
Merged

[stable-2.7] Use UTF-8 encoding for OkHttp credentials if available (sdk > 19) #729

merged 3 commits into from
Oct 18, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #726

@backportbot-nextcloud backportbot-nextcloud bot added this to the NC Android lib 2.7.1 milestone Oct 14, 2021
AlvaroBrey
AlvaroBrey previously approved these changes Oct 14, 2021
View reviewed changes
tobiasKaminsky
tobiasKaminsky previously approved these changes Oct 15, 2021
View reviewed changes
@nextcloud-android-bot
Copy link
Collaborator

IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/548-IT-master

@AlvaroBrey
Copy link
Member

@tobiasKaminsky any idea about the failed test?

com.owncloud.android.lib.resources.shares.UpdateShareRemoteOperationIT > invalidPassword[android-27(AVD) - 8.1.0] FAILED
	junit.framework.ComparisonFailure: expected:<... 10 characters long.[]> but was:<... 10 characters long.[ Password is present in compromised password list. Please choose a different password.]>
	at junit.framework.Assert.assertEquals(Assert.java:85)

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky any idea about the failed test?

com.owncloud.android.lib.resources.shares.UpdateShareRemoteOperationIT > invalidPassword[android-27(AVD) - 8.1.0] FAILED
	junit.framework.ComparisonFailure: expected:<... 10 characters long.[]> but was:<... 10 characters long.[ Password is present in compromised password list. Please choose a different password.]>
	at junit.framework.Assert.assertEquals(Assert.java:85)

This should fix it: #730
NC 22 changed the wording for "invalid password".

@AlvaroBrey
Copy link
Member

/rebase

@AlvaroBrey
Use UTF-8 encoding for OkHttp credentials if available (sdk > 19)
65a4095 
This should allow logging in with usernames containing non-ASCII characters
(only possible with LDAP login).

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
@AlvaroBrey
Move OkHttpCredentialsUtil to nextcloud package
1998d23 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
@AlvaroBrey
Fix ktlint
22697bd 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
@nextcloud-android-bot
Copy link
Collaborator

Lint

Typestable-2.7PR
Warnings12
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings38
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings1
Dodgy code Warnings40
Total126

Lint increased!

@AlvaroBrey AlvaroBrey merged commit 245d253 into stable-2.7 Oct 18, 2021
@delete-merged-branch delete-merged-branch bot deleted the backport/726/stable-2.7 branch October 18, 2021 11:10
@AlvaroBrey AlvaroBrey mentioned this pull request Nov 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlvaroBrey AlvaroBrey AlvaroBrey approved these changes

@tobiasKaminsky tobiasKaminsky tobiasKaminsky left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
NC Android lib 2.7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nextcloud-android-bot @AlvaroBrey @tobiasKaminsky