Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password exception changed on NC22. #730

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Password exception changed on NC22. #730

merged 2 commits into from
Oct 18, 2021

Conversation

tobiasKaminsky
Copy link
Member

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

@tobiasKaminsky
Password exception changed on NC22.
c5c2b02 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky tobiasKaminsky mentioned this pull request Oct 18, 2021
Merged
@tobiasKaminsky
Fix not triggering analysis
1e75725 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

Lint

Typestable-2.7PR
Warnings12
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings38
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings1
Dodgy code Warnings40
Total126

Lint increased!

AlvaroBrey
AlvaroBrey approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@AlvaroBrey AlvaroBrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there were some errors uploading reports (lint and spotbugs both are missing from the server). Otherwise, looks fine!

@tobiasKaminsky
Copy link
Member Author

Strange. Let us not spend time on this. As with next version stable-2.7 will be deprecated.

@tobiasKaminsky tobiasKaminsky merged commit 4183ef5 into stable-2.7 Oct 18, 2021
@delete-merged-branch delete-merged-branch bot deleted the fixPasswordTest branch October 18, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlvaroBrey AlvaroBrey AlvaroBrey approved these changes

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
NC Android lib 2.7.1
Development

Successfully merging this pull request may close these issues.
4 participants
@tobiasKaminsky @nextcloud-android-bot @AlvaroBrey @AndyScherzinger