Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Datepicker localization #2286

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Conversation

georgehrke
Copy link
Member

@georgehrke georgehrke commented May 26, 2020

fixes #2174

fixes first day of week
fixes title of month in header

Before After
datepicker_before 6C199988-3F02-4778-BEB6-A6E8C03DC456

@georgehrke georgehrke added the 2. developing Work in progress label May 26, 2020
@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #2286 into master will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2286      +/-   ##
============================================
- Coverage     27.64%   27.60%   -0.05%     
  Complexity      103      103              
============================================
  Files           144      145       +1     
  Lines          5288     5297       +9     
  Branches        798      798              
============================================
  Hits           1462     1462              
- Misses         3826     3835       +9     
Flag Coverage Δ Complexity Δ
#javascript 22.23% <0.00%> (-0.05%) 0.00 <0.00> (ø)
#php 94.41% <ø> (ø) 103.00 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
src/components/Shared/DatePicker.vue 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/components/Shared/TimePicker.vue 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/utils/localization.js 0.00% <0.00%> (ø) 0.00 <0.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5dd773...9c5f806. Read the comment docs.

@georgehrke georgehrke force-pushed the bugfix/2174/datepicker_localization branch from 83c4a98 to e3eab4c Compare May 26, 2020 10:35
@georgehrke
Copy link
Member Author

georgehrke commented May 26, 2020

src/utils/localization.js still needs some tests, once i added them this is ready to test.

It's a pain to test with mocking moment, will have to find a more elegant solution later.

@tcitworld
Copy link
Member

Didn't have a look yet but from the screenshot short day of week names are not localized.

@georgehrke
Copy link
Member Author

Didn't have a look yet but from the screenshot short day of week names are not localized.

The days names in the screenshot are correctly localised in german:
(Mo)ntag (Di)enstag (Mi)ttwoch ...

@tcitworld
Copy link
Member

I thought that was French. :p

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke force-pushed the bugfix/2174/datepicker_localization branch from e3eab4c to 9c5f806 Compare June 5, 2020 05:22
@georgehrke georgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 5, 2020
@georgehrke georgehrke requested a review from tcitworld June 5, 2020 05:35
@georgehrke georgehrke merged commit 1da604f into master Jun 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the bugfix/2174/datepicker_localization branch June 5, 2020 08:04
@tcitworld tcitworld mentioned this pull request Aug 19, 2020
13 tasks
@dnv
Copy link

dnv commented Feb 20, 2021

Is this getting fixed? My Nextcloud locale is set to English (Finland) with Week starts on Monday clearly shown under Settings, yet the Calendar week starts on Sunday when opened via web browser.

@tcitworld
Copy link
Member

@dnv See #2663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date picker is not localized
3 participants