Dashboard widget

[juliusknorr]

No events	No events today	Events	List with ToDo

Description

This PR implements a basic dashboard widget for Nextcloud 20.

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

How to test / use your changes?

UI Changes

Checklist:

• My code follows the style guidelines of this project
• I signed off my changes (git commit -sm "Your commit message")
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

ToDo

• Check for backward compatibility on older Nextcloud versions
• Fetch a list of upcoming events from the server
• Determine which information we should show per event

[codecov]

Codecov Report

Merging #2414 into master will decrease coverage by 0.04%.
The diff coverage is 27.43%.

@@             Coverage Diff              @@
##             master    #2414      +/-   ##
============================================
- Coverage     30.00%   29.95%   -0.05%     
- Complexity      103      116      +13     
============================================
  Files           149      153       +4     
  Lines          5356     5468     +112     
  Branches        802      811       +9     
============================================
+ Hits           1607     1638      +31     
- Misses         3749     3830      +81     

Flag	Coverage Δ	Complexity Δ
#javascript	24.50% <0.00%> (-0.39%)	0.00 <0.00> (ø)
#php	94.15% <88.57%> (-0.26%)	116.00 <13.00> (+13.00)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
lib/AppInfo/Application.php	0.00% <0.00%> (ø)	3.00 <2.00> (+2.00)
src/dashboard.js	0.00% <0.00%> (ø)	0.00 <0.00> (?)
src/views/Dashboard.vue	0.00% <0.00%> (ø)	0.00 <0.00> (?)
lib/Dashboard/CalendarWidget.php	100.00% <100.00%> (ø)	8.00 <8.00> (?)
lib/Service/JSDataService.php	100.00% <100.00%> (ø)	3.00 <3.00> (?)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25e8523...eb1c1aa. Read the comment docs.

[juliusknorr]

@georgehrke Is there any way we can query the DAV endpoint for something like "the next 10 upcoming events"? Otherwise we probably should have a new HTTP endpoint for that where we collect the relevant list. This would have the benefit that we could also provide the list through the initial state api and reduce loading time when the user sees no information being available in the frontend.

[georgehrke]

No, there is no such endpoint. The problem here are recurring events. There is no way for us to easily query "the next 10 events" or something similar. (Neither via CalDAV nor from the database for that matter)

If you send a calendar-query with a time-range, it will return:

• all non-recurring events in that time-range
• all recurring events:
  • where the first occurrence is earlier than the end-date
  • and where the last occurrence is later than the start-date

The server doesn't actually check whether the recurring event is occurring in that time-range. For example, if you query all events for June, the server will just return all birthday events, even if the person was not born in June.

[georgehrke]

We can just bump to 2.1 and limit it to Nc 20+

[juliusknorr]

Sounds good to me 👍

[georgehrke]

@tcitworld Do you have any objections here?
I would release this as part of Calendar 2.1 and we can always backport bugfixes to 2.0.x when necessary :)

[tcitworld]

Suits me. There's at least #2286 and #2275 that would be nice to have in a close 2.0.x release (maybe released before 20 gets out with 2.1?).

[georgehrke]

[georgehrke]

@jancborchardt I also added a small colored circle with the calendar color.

[juliusknorr]

@georgehrke There seems to be an issue with having only the default personal calendar, in that case there are no requests sent and no events shown. When adding a second calendar only the events of that are shown.

[georgehrke]

@juliushaertl Will check that. Was that calendar enabled?

[jancborchardt]

And an additional thing: If there are no events left for today, can we have an entry saying "All events done for today!" – it could even take 2 rows so it’s clear that today is done. Otherwise you have to check the subline to make sure you got it all.

@georgehrke good example of what I meant by this is in the Talk widget: nextcloud/spreed#3890 (comment)

[georgehrke]

@jancborchardt Please see the updated screenshots in the original post

[jancborchardt]

@jancborchardt Please see the updated screenshots in the original post

Super super super nice! :) Getting 2 issues though:

• The "Create a new event" button seems to not do anything? (fixed by Add routes to allow creating / editing events from outside #2483)
• Clicking on an event initially tries to open a deeplink, but then changes to open just the Dashboard. I do have the index.php in my url path, if that makes a difference. (fixed by Add routes to allow creating / editing events from outside #2483)
• The "No more events today" doesn’t seem to take exactly the space as 2 entries – the calendar entries below don’t line up vertically with those of other widgets.

[georgehrke]

Requires #2483

[georgehrke]

I would like to get #2498 in first, then we can use the icon-font i added for tasks:

[georgehrke]

Good to merge from my side 👍

[georgehrke]

All remarks have been addressed.
Let's get this in, we can always fix smaller issues later.