Better application registering and events dispatching #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
Comment on lines
-37
to
-40
| $app->registerNavigation(); | ||
| $app->registerFilesNavigation(); | ||
| $app->registerFilesPlugin(); | ||
|
|
There was a problem hiding this comment.
I would keep this in here, as it seems that the app.php is loaded only when the app itself is needed.
There was a problem hiding this comment.
During my tests, I saw the listeners (registered in this file) triggered twice each time, so this pull-request fix this issue.
And for the render() method who merge all render methods in one, I borrowed the Talk application
There was a problem hiding this comment.
as it seems that the app.php is loaded only when the app itself is needed.
This should not be the case and therefor it's fine when everything is done in a register method.
But it can be replaced soon for Nextcloud 20:
nextcloud/server#20865
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
This was referenced Sep 20, 2022
This was referenced May 3, 2023
This was referenced Nov 6, 2023
This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
This was referenced Apr 4, 2024
This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.