Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple fixes and add Group Backend support #384

Closed
wants to merge 11 commits into from

Conversation

tortuetorche
Copy link
Contributor

@tortuetorche tortuetorche commented Mar 27, 2020

NOTE: This big pull request will be eventually split in multiple pull requests...

  • Add group_backend option to mirroring the circle as a group (automatically suffixed by Circle)
    You can customize prefix and suffix with the group_backend_name_prefix and group_backend_name_suffix options
    The main goal is to have better integrations with Nextcloud applications and clients. (fix Offer setting so that any circle creates a group #363)
    You should also hide these mirrored circles in Nextcloud applications and clients, because their equivalent group will be used instead, via the allow_listed_circles option set to 0
    • When the group_backend option is enabled, store the mirrored group id in the group_id column of the circles_circles table, useful when the circle's name is updated
    • Add option allow_listed_circles To show (1, default) or hide (0) circles in shared list, disabling this option is very useful when the group_backend option is enabled
    • Exclude personal and secret circles from Group backend, if the group_backend option is enabled
  • Enhance onSettingsChange event to get old setting values (including name and description attributes).
  • Add allow_adding_any_group_members option to allow (1, default) or not adding group members from any users. When value is set to 0 it's not possible anymore to add contacts as circle members for private and public circle types, and it's only possible for groups where the current user is a member or for global administrators. Because they can't be group members, useful when the group_backend option is enabled. There is already the accounts_only option but it applied for any types of circles... (fix Non-admin users should not be able to add group(s) to circles #128)
  • You can now add members in personal circles when skip_invitation_to_closed_circles option is enabled (fix Circle - Can't add persons in personal circle by activating skip invation for closed circle in settings #382 and add users without confirmation in a closed group #360)
  • Fix Parsing error in activities when user request to join a circle (see Parsing error in activities when user request to join a circle #243)
  • Fix CSS
  • Fix translations
  • Fix adding group with member limit -1 or 0 (fix Add group doesn't work with member limit -1|0 #342)

@tortuetorche tortuetorche force-pushed the patches branch 3 times, most recently from e4ee7a9 to 459d92c Compare April 1, 2020 15:06
@tortuetorche
Copy link
Contributor Author

Hi @daita,

Can you tell me if I need to split this big pull request in one pull request per commit, please?

Have a good day,
Tortue Torche

@tortuetorche tortuetorche changed the title [WIP] Multiple fixes and add Group Backend support Multiple fixes and add Group Backend support Apr 7, 2020
@tortuetorche tortuetorche marked this pull request as ready for review April 7, 2020 07:39
@ArtificialOwl
Copy link
Member

Hello,

Thanks for this huge commit, but I would prefer a list of small PR instead ! (also, some of those are already fixed ;p)

Regards,

Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
Fix nextcloud#243

Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
Fix nextcloud#342

Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
…o_closed_circles` option is enabled

Fix nextcloud#382 and
nextcloud#360

Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
Including `name` and `description` attributes

Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
…oup members from any users

Default to `1`.

When value is set to `0` it's only possible to add groups where the
current user is a member or for global administrators.

Fix nextcloud#128

Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
… Circles app

Default value is `1` to show circles in shared list.
Set it to `0` to hide them.

Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
…n the files app

Default is set to `1` to list them in the `files` application
To hide them, set it to `0`

Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
The main goal is to have better integrations with Nextcloud applications
and clients.

The group name is automatically suffixed by ` Circle`
And you can customize the prefix and/or suffix group name with the
`group_backend_name_prefix` and `group_backend_name_suffix` options

You should also hide these mirrored circles in Nextcloud applications
and clients, because their equivalent group will be used instead, via
the `allow_listed_circles` option set to `0`.

Fix nextcloud#363

Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
@tortuetorche
Copy link
Contributor Author

Hi @daita,

Thanks for this huge commit, but I would prefer a list of small PR instead ! (also, some of those are already fixed ;p)

It's done, here my pull requests: #390, #391, #392, #393, #394, #395, #396, #397, #398, #399, #400 and #401!

NB: You should merge them in the ascendant order, otherwise some issues might appears...

Have a good day,
Tortue Torche

@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
81 tasks
@blizzz blizzz modified the milestones: Nextcloud 29, Nextcloud 30 Apr 8, 2024
@joshtrichards
Copy link
Member

Closing since this PR was subsequently handled through split up PRs: #384 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment