Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better 'creation_activity' option handling #396

Conversation

tortuetorche
Copy link
Contributor

@tortuetorche tortuetorche commented Apr 9, 2020

No description provided.

Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
@ArtificialOwl
Copy link
Member

As you saw on #387 the Activity Settings Page now implement a new 'circles_as_non_member' activity feed.

Now, do we really need to keep the creation_activity option ?

1 similar comment
@ArtificialOwl
Copy link
Member

As you saw on #387 the Activity Settings Page now implement a new 'circles_as_non_member' activity feed.

Now, do we really need to keep the creation_activity option ?

@tortuetorche
Copy link
Contributor Author

Now, do we really need to keep the creation_activity option ?

I don't know, I don't use this option, this pull request is just a refactoring of the existing code, to be more readable.

@ArtificialOwl
Copy link
Member

/backport to stable18

@ArtificialOwl ArtificialOwl merged commit b988883 into nextcloud:master Apr 10, 2020
@ArtificialOwl
Copy link
Member

/backport to stable16

@backportbot-nextcloud
Copy link

backport to stable18 in #412

@backportbot-nextcloud
Copy link

backport to stable16 in #413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants