Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing error in activities when user request to join a circle #243

Closed
fgsl opened this issue Oct 16, 2018 · 0 comments · Fixed by #393
Closed

Parsing error in activities when user request to join a circle #243

fgsl opened this issue Oct 16, 2018 · 0 comments · Fixed by #393
Assignees
@fgsl
Labels
4. to release bug

Comments

@fgsl
Copy link
Contributor

fgsl commented Oct 16, 2018

Steps to reproduce

  1. Create a circle of type closed
  2. Log in as other user
  3. Request to join that circle

Expected behaviour

App activity must to show "You sent a request to join circle", where circle is the name of circle.

Actual behaviour

App activity shows "You sent a request to join {circle}". Variable {circle} is not parsed.

Solution

Change call to method setSubject of IEvent by method setSubject of ProviderParser.
@fgsl fgsl self-assigned this Oct 16, 2018
@fgsl fgsl added the bug label Oct 16, 2018
fgsl pushed a commit that referenced this issue Oct 16, 2018
Parsing error in activities when user request to join a circle #243
295b8d6
@fgsl fgsl mentioned this issue Oct 16, 2018
Merged
fgsl added a commit that referenced this issue Oct 29, 2018
@fgsl
Parsing error in activities when user request to join a circle #243
9890efd
ArtificialOwl added a commit that referenced this issue Oct 29, 2018
@ArtificialOwl
Merge pull request #244 from nextcloud/issue243
a6211da 
Parsing error in activities when user request to join a circle #243
@tortuetorche tortuetorche mentioned this issue Mar 27, 2020
Closed
tortuetorche added a commit to tortuetorche/circles that referenced this issue Apr 1, 2020
@tortuetorche
Fix Parsing error in activities when user request to join a circle
dd092f8 
Fix nextcloud#243

Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
tortuetorche added a commit to tortuetorche/circles that referenced this issue Apr 9, 2020
@tortuetorche
Fix Parsing error in activities when user request to join a circle
310d4e5 
Fix nextcloud#243

Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
tortuetorche added a commit to tortuetorche/circles that referenced this issue Apr 9, 2020
@tortuetorche
Fix Parsing error in activities when user request to join a circle
13218f7 
Fix nextcloud#243

Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
This was referenced Apr 9, 2020
Merged
Merged
Open
Merged
backportbot-nextcloud bot pushed a commit that referenced this issue Apr 9, 2020
@tortuetorche @backportbot
Fix Parsing error in activities when user request to join a circle
a7d603e 
Fix #243

Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
backportbot-nextcloud bot pushed a commit that referenced this issue Apr 9, 2020
@tortuetorche @backportbot
Fix Parsing error in activities when user request to join a circle
c25ac8a 
Fix #243

Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fgsl fgsl

Labels
4. to release bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Parsing error in activities when user request to join a circle tortuetorche/circles
2 participants
@fgsl @ArtificialOwl