You can now add members to your own personal circles
#395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o_closed_circles` option is enabled Fix nextcloud#382 and nextcloud#360 Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
| @@ -63,6 +63,7 @@ public function inviteToCircle($circleType) { | |||
| public function joinCircle($circleType) { | |||
|
|
|||
| switch ($circleType) { | |||
| case Circle::CIRCLES_PERSONAL: | |||
There was a problem hiding this comment.
why one should be able to join a Personal Circle ?
There was a problem hiding this comment.
This is necessary when you want to add someone to your own personal circle when the skip_invitation_to_closed_circles option is enabled
There was a problem hiding this comment.
please remove this part, #416 fix this issue
tortuetorche
changed the title
personal circles when `skip_invitation_t…personal circles
tortuetorche
changed the title
personal circlespersonal circles
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
This was referenced Sep 20, 2022
This was referenced May 3, 2023
This was referenced Nov 10, 2023
This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
This was referenced Apr 4, 2024
This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
This was referenced Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
skip_invitation_to_closed_circlesoption is enabledFix #382 and #360