feat(editor): Pass fileId to editor API for reader #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
force-pushed
the
enh/text_attachment_resolver
branch
from
632ce35
to
85b45bb
Compare
Only do this if editor API is version 1.1 or newer to not break usage with older Text versions. This builds on nextcloud/text#5042. Fixes: #620 Fixes: #964 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
enh/text_attachment_resolver
branch
from
85b45bb
to
ed88a22
Compare
juliushaertl
approved these changes
Dec 5, 2023
1 failed test on run #1275 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Page list > Page trash > allows to trash and restore page with subpage and attachment |
Screenshots
|
|
Review all test suite changes for PR #1029 ↗︎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only do this if editor API is version 1.1 or newer to not break usage with older Text versions.
This builds on nextcloud/text#5042.
Fixes: #620
Fixes: #964
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)