Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDF-Attachments are previewed as broken images when clicked in view mode on Nextcloud 26 #620

Closed
niklas-englert opened this issue Mar 28, 2023 · 4 comments · Fixed by #1029
Closed

PDF-Attachments are previewed as broken images when clicked in view mode on Nextcloud 26 #620

niklas-englert opened this issue Mar 28, 2023 · 4 comments · Fixed by #1029
Labels
bug Something isn't working upstream: text

Comments

@niklas-englert
Copy link

Describe the bug
Although bug #396 is now fixed (attachments are rendered as broken images in view mode), the behavior when clicking attachments remains the same: They're previewed as broken images.

To Reproduce
Steps to reproduce the behavior:

  1. Drag & drop a PDF in a Collectives page
  2. Change to view mode (/exit edit mode)
  3. Click on the PDF box (grey outline, red PDF file icon, filename, size)
  4. See a broken image being displayed

Expected behavior
A PDF correct working preview or iframe (or a file download starting).

Screenshots
Collectives_Bug_Preview_PDF

Client details:

  • OS: any
  • Browser: any
  • Version: Nextcloud 26.0.0 / Collectives 2.4.0
  • Device: any
@niklas-englert niklas-englert added the bug Something isn't working label Mar 28, 2023
@mejo-
Copy link
Member

mejo- commented Mar 28, 2023

Thanks for your report @niklas-englert. It's a bug in Nextcloud Text, being tracked in nextcloud/text#3849 and being worked on in nextcloud/text#3924.

@mejo- mejo- mentioned this issue May 19, 2023
Closed
@mejo- mejo- mentioned this issue Nov 27, 2023
Merged
49 tasks
mejo- added a commit that referenced this issue Nov 27, 2023
@mejo-
feat(editor): Pass fileId to editor API for reader
85b45bb 
Only do this if editor API is version 1.1 or newer to not break usage
with older Text versions.

This builds on nextcloud/text#5042.

Fixes: #620
Fixes: #964

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- mentioned this issue Nov 27, 2023
Merged
4 tasks
mejo- added a commit that referenced this issue Dec 5, 2023
@mejo-
feat(editor): Pass fileId to editor API for reader
ed88a22 
Only do this if editor API is version 1.1 or newer to not break usage
with older Text versions.

This builds on nextcloud/text#5042.

Fixes: #620
Fixes: #964

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Dec 5, 2023
@mejo-
feat(editor): Pass fileId to editor API for reader
eb24aea 
Only do this if editor API is version 1.1 or newer to not break usage
with older Text versions.

This builds on nextcloud/text#5042.

Fixes: #620
Fixes: #964

Signed-off-by: Jonas <jonas@freesources.org>
@Jeefongithub
Copy link

I'm experiencing a similar issue in 2.9.2

@mejo-
Copy link
Member

mejo- commented Dec 11, 2023

@Jeefongithub the fix requires Nextcloud 27.1.5 (due date 14. Dec) or 28.0.0 (due date 12. Dec) to be installed. Please report back if you still face this issue after upgrading.

@Jeefongithub
Copy link

upgraded to 27.1.5 rc1 and issue is no longer present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working upstream: text
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(editor): Pass fileId to editor API for reader nextcloud/collectives
3 participants
@mejo- @niklas-englert @Jeefongithub